status and intnotes are now updated after sending email

by sweitmann, Thursday, August 24, 2023, 07:22 (247 days ago)

Hi Hashim,

My colleague Bartosz has asked me regarding this ticket:
https://github.com/ledger123/runmyaccounts/issues/300

He wanted to know if Armaghan had "create the branch to master for this fix?"

I wrote back and explained that we release to develop and then the Run my Accounts/ Infoniqa team release to intergration and master branch as they may see fit. I also wrote that the fix he asked about was released to develop on the 11th of July and sent him the following image and link: [image]

https://github.com/ledger123/runmyaccounts/commit/5c6616fd8e06a1d3273fcd7245c8b7ee8c8e3e5b

Bartoz answered "yes but there's a lot of changes" and sent back this link:
https://github.com/ledger123/runmyaccounts/compare/master...300_notes_regarding_sent_email

Could you please help me explain the "lot of changes" to Bartosz? How can I best answer his question?

Regards

status and intnotes are now updated after sending email

by Armaghan Saqib, Thursday, August 24, 2023, 07:42 (247 days ago) @ sweitmann

Hi Hashim,

My colleague Bartosz has asked me regarding this ticket:
https://github.com/ledger123/runmyaccounts/issues/300

He wanted to know if Armaghan had "create the branch to master for this fix?"

I wrote back and explained that we release to develop and then the Run my Accounts/ Infoniqa team release to intergration and master branch as they may see fit. I also wrote that the fix he asked about was released to develop on the 11th of July and sent him the following image and link: [image]

https://github.com/ledger123/runmyaccounts/commit/5c6616fd8e06a1d3273fcd7245c8b7ee8c8e3e5b

Bartoz answered "yes but there's a lot of changes" and sent back this link:
https://github.com/ledger123/runmyaccounts/compare/master...300_notes_regarding_sent_email

Could you please help me explain the "lot of changes" to Bartosz? How can I best answer his question?

Regards

Hi Sebastian, the link Bartoz has sent is comparing master to our branch. I have never touched this branch (master) so not sure why all these changes are being show.

If you compare develop, you will see that there are not differences as we have already merged the changes we did into develop. This is the link you can use to see the difference between develop and 300_ branch.

https://github.com/ledger123/runmyaccounts/compare/develop...300_notes_regarding_sent_e...

RSS Feed of thread